make ModelName immutable and fix model weight #427
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -175,7 +176,7 @@ type TargetModel struct { | |||
| // Conversely weights are optional, so long as ALL targetModels do not specify a weight. | |||
| // | |||
| // +optional | |||
| // +kubebuilder:validation:Minimum=0 | |||
| // +kubebuilder:validation:Minimum=1 | |||
There was a problem hiding this comment.
It set to 0, it will panic too
There was a problem hiding this comment.
Can we allow to set 0 weight which users can do so to disabled the model instead of removing the model?
There was a problem hiding this comment.
A similar question came up in Gateway API and we ultimately decided that we'd rather have people remove the backend altogether to avoid any confusion. In practice this likely just means commenting out some YAML. I'd prefer to follow the same pattern here.
|
Thanks @hzxuzhonghu! /lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Fix #426
Fix #408