Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Ready" Condition with "Accepted" #444

Closed
Tracked by #362
robscott opened this issue Mar 3, 2025 · 1 comment · Fixed by #446
Closed
Tracked by #362

Replace "Ready" Condition with "Accepted" #444

robscott opened this issue Mar 3, 2025 · 1 comment · Fixed by #446
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@robscott
Copy link
Member

robscott commented Mar 3, 2025

What happened:
The "Ready" condition adds unnecessary overhead for Gateway controllers and goes against Gateway API's decision to avoid a "Ready" condition. We should remove it until we have a very clear definition and use case for it.

What you expected to happen:
We really don't want to require controllers to constantly update "Ready" status on InferencePool based on the readiness of underlying Pods. We've intentionally avoided a "Ready" condition in Gateway API, and I'd recommend leaving it out of this release until we can have a clearer definition and consensus around this.

@robscott robscott added the kind/bug Categorizes issue or PR as related to a bug. label Mar 3, 2025
@robscott
Copy link
Member Author

robscott commented Mar 3, 2025

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
1 participant