Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Accepted and ResolvedRefs conditions to InferencePool #446

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

robscott
Copy link
Member

@robscott robscott commented Mar 4, 2025

@k8s-ci-robot
Copy link
Contributor

@robscott: GitHub didn't allow me to request PR reviews from the following users: nicolexin.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes #190
Fixes #444

/cc @danehans @ahg-g @kfswain @nicolexin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2025
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit ac1a051
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67c65f439fb6260008a8bc31
😎 Deploy Preview https://deploy-preview-446--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfswain
Copy link
Collaborator

kfswain commented Mar 4, 2025

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit ddd066a into kubernetes-sigs:main Mar 4, 2025
8 checks passed
Copy link
Contributor

@nicolexin nicolexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Rob!

Just one minor nit: Can we also update the default on line 177? I am assuming the CRD is going to be initialized with this, currently still refers to the "Ready" type.

// +kubebuilder:default={{type: "Ready", status: "Unknown", reason:"Pending", message:"Waiting for controller", lastTransitionTime: "1970-01-01T00:00:00Z"}}

Copy link
Contributor

@nicolexin nicolexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nit I noticed:
On line 235, line 239, line 244: Do we want to call these const InferencePoolConditionResolvedRefs / InferencePoolReaonResolvedRefs / InferencePoolReasonInvalidExtensionRef instead?

(they all have the Model* prefix right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "Ready" Condition with "Accepted" Introduce ResolvedRefs Status Condition
4 participants