-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Accepted and ResolvedRefs conditions to InferencePool #446
Conversation
@robscott: GitHub didn't allow me to request PR reviews from the following users: nicolexin. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much Rob!
Just one minor nit: Can we also update the default on line 177? I am assuming the CRD is going to be initialized with this, currently still refers to the "Ready" type.
// +kubebuilder:default={{type: "Ready", status: "Unknown", reason:"Pending", message:"Waiting for controller", lastTransitionTime: "1970-01-01T00:00:00Z"}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another nit I noticed:
On line 235, line 239, line 244: Do we want to call these const InferencePoolConditionResolvedRefs / InferencePoolReaonResolvedRefs / InferencePoolReasonInvalidExtensionRef instead?
(they all have the Model* prefix right now)
Fixes #190
Fixes #444
/cc @danehans @ahg-g @kfswain @nicolexin