Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics on metric probing #50

Open
liu-cong opened this issue Nov 20, 2024 · 2 comments
Open

Add metrics on metric probing #50

liu-cong opened this issue Nov 20, 2024 · 2 comments
Assignees

Comments

@liu-cong
Copy link
Contributor

liu-cong commented Nov 20, 2024

  • Latency: Low metric fetch latency is crucial as the load balancing algorithm relies on near real time metrics from the model servers. Therefore it's important to monitor the metric fetch latency.
    Currently we simply log the latency, we should integrate Prometheus and add a Histogram metric.
  • Error count. This can help detect bad backends.

Other consideration: We may need to sample the metrics instead of recording every probing call, due to the high probing frequency.

@MadhavJivrajani
Copy link
Contributor

I'd like to try this out
/assign

@kfswain
Copy link
Collaborator

kfswain commented Feb 19, 2025

@JeffLuoo just an FYI

@liu-cong liu-cong changed the title Add FetchMetricLatency metric Add metrics on metric probing Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants