Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics] Add request error metrics #269

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

JeffLuoo
Copy link
Contributor

This change defines some general errors, the list might grow in the future if more finer error types are needed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @JeffLuoo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit f3c34bd
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67b619edf784e200083889bd
😎 Deploy Preview https://deploy-preview-269--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2025
@JeffLuoo JeffLuoo marked this pull request as draft January 31, 2025 22:08
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@JeffLuoo JeffLuoo marked this pull request as ready for review January 31, 2025 22:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and Jeffwan January 31, 2025 22:11
@JeffLuoo
Copy link
Contributor Author

@liu-cong @courageJ tag for review

@ahg-g
Copy link
Contributor

ahg-g commented Feb 3, 2025

/ok-to-test

If you don't mind, I would like to getting #271 in first since it is required for the release.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Feb 7, 2025

To fix the test error, please remove gci from the list of linters: https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/.golangci.yml#L17

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2025
@JeffLuoo JeffLuoo requested a review from liu-cong February 14, 2025 20:54
Copy link
Contributor

@liu-cong liu-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an integration test for this? The code path is pretty complex now, especially due to the streaming processing, an integration test can give us higher confidence.

See #326. Feel free to defer to a follow up change.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2025
@JeffLuoo JeffLuoo requested a review from courageJ February 18, 2025 14:25
@JeffLuoo JeffLuoo requested a review from liu-cong February 18, 2025 14:25
@JeffLuoo JeffLuoo force-pushed the error-metrics branch 2 times, most recently from 063cb05 to dace5b4 Compare February 18, 2025 15:24
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2025
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more rebase, and this should be good to go.

Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we track metrics probing errors too? the probing that the provider does to get server load.

This change defines some general errors, the list might grow in the future if more finer error types are needed.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2025
@JeffLuoo JeffLuoo requested review from liu-cong and ahg-g February 19, 2025 17:55
@JeffLuoo
Copy link
Contributor Author

@ahg-g Can you provide more context on the question? Do you mean tracking errors when:

  • EPP server fails to service /metrics endpoint
  • Monitoring solutions (Prometheus or GMP) fail to scrape the /metrics endpoint of EPP

@liu-cong
Copy link
Contributor

Can we track metrics probing errors too? the probing that the provider does to get server load.

Yeah we should add these, but I recommend in a follow up. This is tracked in #50 (comment)

@liu-cong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Feb 19, 2025

/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, JeffLuoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6130ee0 into kubernetes-sigs:main Feb 19, 2025
8 checks passed
rramkumar1 pushed a commit to rramkumar1/gateway-api-inference-extension that referenced this pull request Mar 3, 2025
This change defines some general errors, the list might grow in the future if more finer error types are needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants