-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics] Add request error metrics #269
Conversation
Hi @JeffLuoo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4f90f79
to
257d2fa
Compare
/ok-to-test If you don't mind, I would like to getting #271 in first since it is required for the release. |
To fix the test error, please remove |
257d2fa
to
513ae62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an integration test for this? The code path is pretty complex now, especially due to the streaming processing, an integration test can give us higher confidence.
See #326. Feel free to defer to a follow up change.
513ae62
to
7a91432
Compare
063cb05
to
dace5b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one more rebase, and this should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we track metrics probing errors too? the probing that the provider does to get server load.
This change defines some general errors, the list might grow in the future if more finer error types are needed.
dace5b4
to
f3c34bd
Compare
@ahg-g Can you provide more context on the question? Do you mean tracking errors when:
|
Yeah we should add these, but I recommend in a follow up. This is tracked in #50 (comment) |
/lgtm |
/approve Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, JeffLuoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change defines some general errors, the list might grow in the future if more finer error types are needed.
This change defines some general errors, the list might grow in the future if more finer error types are needed.