Skip to content

Add a metric to track number of ready pods #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahg-g opened this issue Mar 28, 2025 · 2 comments · Fixed by #622
Closed

Add a metric to track number of ready pods #599

ahg-g opened this issue Mar 28, 2025 · 2 comments · Fixed by #622

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Mar 28, 2025

What would you like to be added:

A metric emitted by the EPP to track the number of ready pods from the EPP PoV.

Why is this needed:

The EPP doesn't own the status of the InferencePool object, so it can't keep track of that there. Having a metric to track the number of ready pods is important for operators to track rollouts.

@smarterclayton
Copy link
Contributor

We probably should plan to break that metric down by attributes the pool is aware of (i.e. not O(pods), but O(groups of pods under the pool)). We don't have such a label, but I can already see ones coming up like heterogenity and assignment.

@JeffLuoo
Copy link
Contributor

JeffLuoo commented Mar 28, 2025

I have an idea to add a new metric for inference pool

inference_pool_per_pod_queue_size{name=<inference pool name>, pod=<name of pod under the pool>}

which tells the total number queue for each pod under the pool. It can provide:

  1. number of pods related to the pool.
  2. queue length for each pod, and see if our scheduling algorithm (or the priority) works as intended.

WDYT? @ahg-g @smarterclayton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants