Skip to content

[Metrics] Add number of ready pods metric for inference pool #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

[Metrics] Add number of ready pods metric for inference pool #622

merged 1 commit into from
Mar 31, 2025

Conversation

JeffLuoo
Copy link
Contributor

@JeffLuoo JeffLuoo commented Mar 31, 2025 •
edited
Loading

resolve #599

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 31, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 54cc746
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67eb28418131d70008f3ed98
😎 Deploy Preview https://deploy-preview-622--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ahg-g
ahg-g reviewed Mar 31, 2025
View reviewed changes
@JeffLuoo JeffLuoo changed the title [Metrics] Add number of running pods metric for inference pool [Metrics] Add number of ready pods metric for inference pool Mar 31, 2025
@JeffLuoo JeffLuoo requested a review from ahg-g March 31, 2025 23:32
ahg-g
ahg-g reviewed Mar 31, 2025
View reviewed changes
@JeffLuoo JeffLuoo requested a review from ahg-g March 31, 2025 23:40
@ahg-g
Copy link
Contributor

ahg-g commented Mar 31, 2025

/lgtm
/approve

Thanks for quickly adding those important metrics!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, JeffLuoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit d365758 into kubernetes-sigs:main Mar 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfswain kfswain Awaiting requested review from kfswain

@robscott robscott Awaiting requested review from robscott

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a metric to track number of ready pods
3 participants
@JeffLuoo @ahg-g @k8s-ci-robot