Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed repo structure + copy of initial proposal #1

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Aug 29, 2024

Creating repo skeletal structure that this repo should follow. Also populating the proposals section with the initial proposal that corresponded with the repo creation.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kfswain
Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @kfswain!

It looks like this is your first PR to kubernetes-sigs/llm-instance-gateway 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/llm-instance-gateway has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit e121718 into kubernetes-sigs:main Aug 30, 2024
1 of 2 checks passed
@terrytangyuan
Copy link
Member

Something seems wrong with GitHub. Your PR was merged without LGTM/approval. The changes are not on main branch either.

@kfswain
Copy link
Collaborator Author

kfswain commented Aug 30, 2024

It was my local git. I had the owners branch based off this one (I made a revert commit there to remove the changes.) I rebased to my main, which should have done the trick. Ah well, I'll make a new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants