Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes PoolRef to a Value Type #112

Closed
wants to merge 1 commit into from

Conversation

danehans
Copy link
Contributor

Changes inferencemodel.spec.poolRef to a value type since it's required.

Fixes #111

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danehans
Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2024
@kfswain
Copy link
Collaborator

kfswain commented Dec 19, 2024

Heya thanks for this! I just happened to see you make the issue and was fixing this along with some other issues.

There were some tests we had to update also that have a ref type, I included that. PR here: #114

If you're curious about our need for CI. I agree.
That PR here: kubernetes/test-infra#33987
Difficult to get review traction

@danehans
Copy link
Contributor Author

@kfswain thanks for the heads-up. I searched the issue list and saw nothing related to #111 so I pushed this PR. I'll go ahead and close it since #114 fixes this issue. I'll do a review of #114 now.

@danehans
Copy link
Contributor Author

Closed due to #112 (comment).

@danehans danehans closed this Dec 19, 2024
@danehans danehans deleted the issue_111 branch December 19, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PoolRef is Required and a Pointer Type
3 participants