Skip to content

Disable response body processing #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Disable response body processing #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions examples/poc/manifests/gateway/enable_patch_policy.yaml
View file
Open in desktop

This file was deleted.

69 changes: 0 additions & 69 deletions examples/poc/manifests/gateway/ext_proc.yaml
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions examples/poc/manifests/gateway/gateway.yaml
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions examples/poc/manifests/gateway/patch_policy.yaml
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions pkg/ext-proc/handlers/response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ func (s *Server) HandleResponseHeaders(reqCtx *RequestContext, req *extProcPb.Pr
}

// HandleResponseBody parses response body to update information such as number of completion tokens.
// NOTE: The current implementation only supports Buffered mode, which is not enabled by default. To
// use it, you need to configure EnvoyExtensionPolicy to have response body in Buffered mode.
// https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/ext_proc/v3/processing_mode.proto#envoy-v3-api-msg-extensions-filters-http-ext-proc-v3-processingmode
// Example response
/*
{
Expand Down
1 change: 0 additions & 1 deletion pkg/manifests/ext_proc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ spec:
request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have files in https://github.com/kubernetes-sigs/gateway-api-inference-extension/tree/main/examples/poc/manifests/gateway too, are those still relevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed them. They are already outdated.

body: Buffered
response:
body: Buffered
# The timeouts are likely not needed here. We can experiment with removing/tuning them slowly.
# The connection limits are more important and will cause the opaque: ext_proc_gRPC_error_14 error in Envoy GW if not configured correctly.
messageTimeout: 1000s
Expand Down