-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates APIs Based on Kubernetes API Conventions #143
Conversation
Signed-off-by: Daneyon Hansen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, the rest of this PR LGTM, thanks for all the great work on this @danehans!
Signed-off-by: Daneyon Hansen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danehans!
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, danehans, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Implements the following changes based on Kubernetes API conventions:
RenamestargetPortNumber
totargetPort
to provide naming consistency with Gateway API and Kubernetes API conventions.inferencemodel.spec.modelName
a required field.targetPortNumber
to be consistent with Gateway API and Kubernetes API types.Updates examples based on previous API changes and changes introduced by this PR.