Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates APIs Based on Kubernetes API Conventions #143

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Jan 2, 2025

Implements the following changes based on Kubernetes API conventions:

  • Renames targetPortNumber to targetPort to provide naming consistency with Gateway API and Kubernetes API conventions.
  • Moves InferenceModel, InferenceModelList InferencePool, and InferencePoolList definitions to the top of the files.
  • Makes inferencemodel.spec.modelName a required field.
  • Updates the minimum value of targetPortNumber to be consistent with Gateway API and Kubernetes API types.
  • Runs code generators to regenerate DeepCopy functions, CRD manifests, etc.
  • Updates examples based on previous API changes and changes introduced by this PR.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 2, 2025
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, the rest of this PR LGTM, thanks for all the great work on this @danehans!

@danehans danehans requested a review from ahg-g January 3, 2025 18:28
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danehans!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jan 3, 2025

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, danehans, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit a0cdf8f into kubernetes-sigs:main Jan 3, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants