Skip to content

.*: change llm-instance-gateway -> gateway-api-inference-extension #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

MadhavJivrajani
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani commented Jan 7, 2025

This PR renames the main module from inference.networking.x-k8s.io/llm-instance-gateway to inference.networking.x-k8s.io/gateway-api-inference-extension and also changes the name in module imports and some scripts.

Note: I've also changed the name in comments that include the old repo name. While this isn't strictly needed since GitHub has redirects in place, I'm not sure if those redirects will always remain.

Fixes #159

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 7, 2025
@MadhavJivrajani
Copy link
Contributor Author

/assign @danehans

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 7, 2025
@MadhavJivrajani
Copy link
Contributor Author

There's also https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/PROJECT

Considering this was generated at bootstrap time and edited once after the API was renamed, is it okay we edit this manually?

@ahg-g
Copy link
Contributor

ahg-g commented Jan 7, 2025

There's also https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/PROJECT

Considering this was generated at bootstrap time and edited once after the API was renamed, is it okay we edit this manually?

We can change it manually

Signed-off-by: Madhav Jivrajani <[email protected]>
@MadhavJivrajani
Copy link
Contributor Author

Done @ahg-g, thanks!

@ahg-g
Copy link
Contributor

ahg-g commented Jan 7, 2025

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0070f21 into kubernetes-sigs:main Jan 7, 2025
4 checks passed
courageJ pushed a commit to courageJ/llm-instance-gateway that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Module
4 participants