-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ext-proc Main with Server Package Add Hermetic Test with k8s API Client for EPP #222
Conversation
Welcome @BenjaminBraunDev! |
Hi @BenjaminBraunDev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few initial comments, I didn't look at the test itself yet
Can we split this PR into two? One that refactors main and one that adds the test please? This will help us unblock #225 (comment) |
This is great, can you please run the e2e test to test the changes? We don't run it in presubmit now because it requires a HF token. Also, can you please open an issue to track the work to use ginkgo for integration tests? |
…mmented out logging code.
…start manager in main blocking
…e k8s API logic into a BeforeSuite() function run before the hermetic tests
…rmatting and helper functions for runserver.
f29c899
to
ea4a531
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, BenjaminBraunDev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/hold cancel |
This adds a a hermetic test that creates a k8s Client with InferenceModel and InferencePool objects for use with the ext-proc server. It also refactors main to instead call functions defined in a new server package, this is a preliminary step in developing a full 2E2 test for the ext-proc server.
Related Issue: Issue #80 Add more hermetic tests