Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Getting Started updates #233

Merged
merged 1 commit into from
Jan 27, 2025
Merged

More Getting Started updates #233

merged 1 commit into from
Jan 27, 2025

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Jan 27, 2025

  • Fixing CRD installation to reference the directory with a kustomize file in it.
  • updating readme to pull the raw yaml files directly from GH
  • locking the EPP to a specific hash

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 27, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 66505b8
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67980cb2d4794e0008c1b031
😎 Deploy Preview https://deploy-preview-233--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfswain
Copy link
Collaborator Author

kfswain commented Jan 27, 2025

We can lock the yaml files to a specific commit hash if we want. It just reads cleaner this way, and I figure we want the Getting Started guide to stay reasonably up to date with changes.

Dealers choice

@kfswain
Copy link
Collaborator Author

kfswain commented Jan 27, 2025

We can lock the yaml files to a specific commit hash if we want. It just reads cleaner this way, and I figure we want the Getting Started guide to stay reasonably up to date with changes.

Dealers choice

The issue is that it would have to be a following PR, cause I need to update the manifests here, and I think the squash generates a distinct hash

ahg-g
ahg-g reviewed Jan 27, 2025
View reviewed changes
pkg/manifests/ext_proc.yaml
@@ -60,7 +60,7 @@ spec:
containers:
- name: inference-gateway-ext-proc
# TODO(https://github.com/kubernetes-sigs/gateway-api-inference-extension/issues/34) Update the image and args.
image: us-central1-docker.pkg.dev/k8s-staging-images/llm-instance-gateway/epp:main
image: us-central1-docker.pkg.dev/k8s-staging-images/llm-instance-gateway/epp@sha256:1ef39ee79c55db6436f9d4cb14cc957dea647f57b8a7ff0363f60b0711695103
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we open an issue to track this regression pls to describe what kind of regression main currently has?

@ahg-g
Copy link
Contributor

ahg-g commented Jan 27, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
robscott
robscott reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kfswain! Do you mind adding/moving this to https://gateway-api-inference-extension.sigs.k8s.io/guides/?

@k8s-ci-robot k8s-ci-robot merged commit ff9cbe7 into kubernetes-sigs:main Jan 27, 2025
8 checks passed
@danehans danehans mentioned this pull request Jan 28, 2025
Closed
@kfswain
Copy link
Collaborator Author

kfswain commented Jan 28, 2025

@robscott yes, definitely. Will do today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@ahg-g ahg-g ahg-g left review comments

@danehans danehans Awaiting requested review from danehans

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kfswain @k8s-ci-robot @ahg-g @robscott