Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority based scheduling #25

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Oct 21, 2024

Benchmark results for critical vs. sheddable requests. Pls find more details of the benchmark in this doc:
https://docs.google.com/document/d/11ALHEF-9yOaLdbHbDjBoTY6fzejoEKiSYHzWpWqe8ZY/edit?tab=t.0#bookmark=id.gx5ki34wov48

Critical request:
image

Sheddable requests:
image

Success ratio for sheddable requests:

QPS Success ratio
1.5 100.00%
3 100.00%
4.5 100.00%
6 100.00%
9 100.00%
12 100.00%
15 100.00%
18 97.56%
21 77.33%
24 58.88%
27 49.11%
30 36.77%
33 27.79%
36 19.11%
39 15.10%
42 13.48%
45 13.11%
48 12.56%
51 10.59%
54 11.31%
57 9.35%
60 8.58%

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g October 21, 2024 17:49
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kfswain October 21, 2024 17:49
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
@kfswain
Copy link
Collaborator

kfswain commented Oct 22, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Oct 24, 2024

the y-axis label for the middle graphs looks like it is indicating throughput, I guess you meant to say average per token latency in minutes?

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit d122a6c into kubernetes-sigs:main Oct 24, 2024
2 checks passed
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Oct 28, 2024
* Add priority based scheduling

* Use the least kv cache for sheddable requests when there is capacity
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Oct 28, 2024
* Add priority based scheduling

* Use the least kv cache for sheddable requests when there is capacity
@liu-cong liu-cong deleted the prio branch October 28, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants