Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unintended % in e2e InferenceModel #250

Closed
wants to merge 1 commit into from

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Jan 29, 2025

Removes an unintended % character in the e2e InferenceModel. The e2e test now passes and validates load balancing across two LoRA adapters (tweet-summary-0 and tweet-summary-1):

$ make test-e2e
...
Ran 1 of 1 Specs in 174.487 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAPIs (174.49s)
PASS
ok  	inference.networking.x-k8s.io/gateway-api-inference-extension/test/e2e	174.515s

Fixes #249

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2025
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 6c5eba6
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/679a556f1144d70008e5ac66
😎 Deploy Preview https://deploy-preview-250--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danehans danehans requested a review from ahg-g January 29, 2025 16:21
@danehans danehans mentioned this pull request Jan 29, 2025
@danehans
Copy link
Contributor Author

#246 also fixes #249 but introduces other changes.

@ahg-g
Copy link
Contributor

ahg-g commented Jan 29, 2025

I think we need the changes in #246 to ensure that the test doesn't flake

@danehans
Copy link
Contributor Author

Closing in favor of #246

@danehans danehans closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InferenceModel for e2e Test Contains Incorrect TargetModel
3 participants