Skip to content

In hermetic test, add additional test cases and move k8sClient object creation so it's called once for all tests #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 7, 2025

Conversation

BenjaminBraunDev
Copy link
Contributor

Adds additional testing for EPP logic for selecting model servers for an inference request. The two new test cases check:

  1. If there is no active LoRA for a request for one, the behavior is based solely off queue size and KV-utilization.
  2. If there is an active LoRA model but the queue size is above the schedulers threshold value queueingThresholdLoRA than a lower queue size model is chosen despite the higher already having the requested LoRA active to avoid overloading a heavy traffic model.

This also moves the logic for adding test InferenceModel and InferencePool objects into the k8sClient into the BeforeSuit() so it's only called once, otherwise it will error upon trying to create duplicate objects.

Related Issue: #80

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨
… setup to BeforeSuit() so it is set up once for all test cases. Add getter function to scheduling to reference queue threshold for lora affinity inside integration tests.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @BenjaminBraunDev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2025
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 68c91e4
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67a54f6ecc89590008566f27
😎 Deploy Preview https://deploy-preview-278--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…ts, remove unreachable error check.
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Feb 6, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 6, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Feb 6, 2025

/approve

leaving lgtm to @liu-cong

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, BenjaminBraunDev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
… non-lora test case to use a different model name.
@liu-cong
Copy link
Contributor

liu-cong commented Feb 7, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3ff0af8 into kubernetes-sigs:main Feb 7, 2025
8 checks passed
@BenjaminBraunDev BenjaminBraunDev deleted the test-cases branch February 7, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants