Add a hermetic e2e test with fake backend pods #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
liu-cong
commented
Oct 23, 2024
There was a problem hiding this comment.
Moved from pkg/ext-proc/benchmark/benchmark.go, no new code
The test spins up an ext proc server locally with fake backend pods, sends requests, and then inspects the response headers to check the expected backend pod is selected. It tests the code e2e except for the model server specific metric scraping code.
ahg-g
reviewed
Oct 26, 2024
| return client, func() { | ||
| cancel() | ||
| conn.Close() | ||
| server.GracefulStop() |
There was a problem hiding this comment.
is this going to kill the go routine that started the server here https://github.com/kubernetes-sigs/llm-instance-gateway/pull/29/files#diff-8dd426243c10996d6a7c647c65b54d42d7a962c9be63e45fe8253e9a2612a2c7R48 ?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, liu-cong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test spins up an ext proc server locally with fake backend pods, sends requests, and then inspects the response headers to check the expected backend pod is selected.
It tests the code e2e except for the model server specific metric scraping code.