Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds e2e test script #294

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Feb 6, 2025

Adds an e2e test script that supports the POC and e2e deployment modes, e.g. gtw default/inference-gateway or svc default/envoy for the endpoint IP/port.

Signed-off-by: Daneyon Hansen <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2025
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 438f63c
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67ae2b12dfae990008de3392
😎 Deploy Preview https://deploy-preview-294--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we name it test-guide-e2e.sh since it only tests the guide?

@ahg-g
Copy link
Contributor

ahg-g commented Feb 11, 2025

@danehans did you want to address the nit to merge this?

Signed-off-by: Daneyon Hansen <[email protected]>
@danehans
Copy link
Contributor Author

Perhaps we name it test-guide-e2e.sh since it only tests the guide?

Commit 438f63c keeps the name b/c it will test e2e based on either the quickstart or e2e setup.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 13, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit db21e9e into kubernetes-sigs:main Feb 13, 2025
7 of 8 checks passed
@danehans danehans deleted the e2e_script branch February 13, 2025 18:47
coolkp pushed a commit to coolkp/llm-instance-gateway that referenced this pull request Feb 13, 2025
* feat: Adds e2e test script

Signed-off-by: Daneyon Hansen <[email protected]>

* Docs the e2e test script

Signed-off-by: Daneyon Hansen <[email protected]>

---------

Signed-off-by: Daneyon Hansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants