Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing small linter complaints #302

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fixing small linter complaints #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions api/v1alpha1/inferencemodel_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ type InferenceModelConditionType string
type InferenceModelConditionReason string

const (
// This condition indicates if the model config is accepted, and if not, why.
// ModelConditionAccepted indicates if the model config is accepted, and if not, why.
//
// Possible reasons for this condition to be True are:
//
Expand All @@ -218,14 +218,14 @@ const (
//
ModelConditionAccepted InferenceModelConditionType = "Accepted"

// Desired state. Model conforms to the state of the pool.
// ModelReasonAccepted is the desired state. Model conforms to the state of the pool.
ModelReasonAccepted InferenceModelConditionReason = "Accepted"

// This reason is used when a given ModelName already exists within the pool.
// ModelReasonNameInUse is used when a given ModelName already exists within the pool.
// Details about naming conflict resolution are on the ModelName field itself.
ModelReasonNameInUse InferenceModelConditionReason = "ModelNameInUse"

// This reason is the initial state, and indicates that the controller has not yet reconciled the InferenceModel.
// ModelReasonPending is the initial state, and indicates that the controller has not yet reconciled the InferenceModel.
ModelReasonPending InferenceModelConditionReason = "Pending"
)

Expand Down
8 changes: 4 additions & 4 deletions api/v1alpha1/inferencepool_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ type InferencePoolConditionType string
type InferencePoolConditionReason string

const (
// This condition indicates if the pool is ready to accept traffic, and if not, why.
// PoolConditionReady indicates if the pool is ready to accept traffic, and if not, why.
//
// Possible reasons for this condition to be True are:
//
Expand All @@ -223,13 +223,13 @@ const (
//
PoolConditionReady InferencePoolConditionType = "Ready"

// Desired state. The pool and its components are initialized and ready for traffic.
// PoolReasonReady is the desired state. The pool and its components are initialized and ready for traffic.
PoolReasonReady InferencePoolConditionReason = "Ready"

// This reason is used when the EPP has not yet passed health checks, or has started failing them.
// PoolReasonEPPNotHealthy is used when the EPP has not yet passed health checks, or has started failing them.
PoolReasonEPPNotHealthy InferencePoolConditionReason = "EndpointPickerNotHealthy"

// This reason is the initial state, and indicates that the controller has not yet reconciled this pool.
// PoolReasonPending is the initial state, and indicates that the controller has not yet reconciled this pool.
PoolReasonPending InferencePoolConditionReason = "Pending"
)

Expand Down