Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to the adapter rollouts guide #338

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Fixes to the adapter rollouts guide #338

merged 3 commits into from
Feb 18, 2025

Conversation

ahg-g
Copy link
Contributor

@ahg-g ahg-g commented Feb 14, 2025

Fixes #257

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 14, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit adb02fc
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67b13c5df8bcdb0009f6cf15
😎 Deploy Preview https://deploy-preview-338--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 14, 2025

/hold

I have a few more fixes

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2025
@ahg-g ahg-g force-pushed the syncer3 branch 8 times, most recently from 53f383c to e27c0ea Compare February 15, 2025 01:29
@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 15, 2025

/hold cancel

This is ready.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2025
@ahg-g ahg-g force-pushed the syncer3 branch 2 times, most recently from bacbacc to a01cdf0 Compare February 15, 2025 01:44
@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 15, 2025

/assign @liu-cong

coolkp
coolkp reviewed Feb 15, 2025
View reviewed changes
pkg/manifests/vllm/deployment.yaml Outdated
env:
- name: DYNAMIC_LORA_ROLLOUT_CONFIG
value: "/config/configmap.yaml"
volumeMounts: # DO NOT USE subPath
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call out the subPath limitation in the guide, i mentioned it in the readme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave that to the tool's detailed guide itself. Btw, I think we may want to force a regular sync, like every 5sec in case we miss notifications for some reason. Users should also be able to define a default base model. I will create enhancements issues as follow ups.

coolkp
coolkp approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@coolkp coolkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@coolkp: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, coolkp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

liu-cong
liu-cong reviewed Feb 15, 2025
View reviewed changes
site-src/guides/adapter-rollout.md
Follow the steps in the [main guide](index.md)


## **Safely rollout v2 adapter**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## **Safely rollout v2 adapter**
## Safely rollout v2 adapter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is correct, I want the level 2 header to be bold.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the headers in bold by default? Anyway not a big deal.

ahg-g
ahg-g commented Feb 15, 2025
View reviewed changes
Copy link
Contributor Author

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liu-cong

site-src/guides/adapter-rollout.md
Follow the steps in the [main guide](index.md)


## **Safely rollout v2 adapter**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is correct, I want the level 2 header to be bold.

@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 16, 2025

Pushed the changes

@liu-cong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 755b81b into kubernetes-sigs:main Feb 18, 2025
8 checks passed
@kfswain kfswain mentioned this pull request Feb 19, 2025
Closed
rramkumar1 pushed a commit to rramkumar1/gateway-api-inference-extension that referenced this pull request Mar 3, 2025
@ahg-g @rramkumar1
Fixes to the adapter rollouts guide (kubernetes-sigs#338)
23cd81b 
* Polishing to the adapter rollouts guide

* Make all guides use the same deployment so that we can till one story as the user navigates through the guides

* Addressed comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liu-cong liu-cong liu-cong left review comments

@coolkp coolkp coolkp approved these changes

@kfswain kfswain Awaiting requested review from kfswain

@robscott robscott Awaiting requested review from robscott

Assignees

@liu-cong liu-cong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guide for multi-LoRA rollout story
4 participants
@ahg-g @k8s-ci-robot @liu-cong @coolkp