-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rm v1alpha1 api #405
Rm v1alpha1 api #405
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cc @ahg-g |
pls update the yamls in test/testdata |
Heya @hzxuzhonghu! Thanks for this! Have we validated that the resultant image from this change, and the manifests all work? Understood that this is a massive PR, but I think with such a large change I just want to make sure we aren't breaking ourselves |
Good point, i do think we need to update the image to support v1alpha2. So who can trigger that? |
Can you please update the yamls in the repo to point to v1alpha2? I will run the e2e test once you do. |
I updated the yamls in #420 and test this PR with the one that updates the yamls, works as expected |
/lgtm Thanks to both of you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FIX #401
Explicitly document cross namespace pod selection is unallowed