Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm v1alpha1 api #405

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Rm v1alpha1 api #405

merged 3 commits into from
Feb 27, 2025

Conversation

hzxuzhonghu
Copy link
Member

@hzxuzhonghu hzxuzhonghu commented Feb 25, 2025

FIX #401

Explicitly document cross namespace pod selection is unallowed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2025
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7001c32
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67bebe635488f50008e54e4c
😎 Deploy Preview https://deploy-preview-405--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 25, 2025
@hzxuzhonghu
Copy link
Member Author

cc @ahg-g

@ahg-g
Copy link
Contributor

ahg-g commented Feb 26, 2025

pls update the yamls in test/testdata

@kfswain
Copy link
Collaborator

kfswain commented Feb 26, 2025

Heya @hzxuzhonghu! Thanks for this! Have we validated that the resultant image from this change, and the manifests all work?

Understood that this is a massive PR, but I think with such a large change I just want to make sure we aren't breaking ourselves

@hzxuzhonghu
Copy link
Member Author

hzxuzhonghu commented Feb 27, 2025

Have we validated that the resultant image from this change, and the manifests all work?

Good point, i do think we need to update the image to support v1alpha2. So who can trigger that?

@ahg-g
Copy link
Contributor

ahg-g commented Feb 27, 2025

Can you please update the yamls in the repo to point to v1alpha2? I will run the e2e test once you do.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 27, 2025

I updated the yamls in #420 and test this PR with the one that updates the yamls, works as expected

@kfswain
Copy link
Collaborator

kfswain commented Feb 27, 2025

/lgtm
/approve

Thanks to both of you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 10133ba into kubernetes-sigs:main Feb 27, 2025
8 checks passed
@hzxuzhonghu hzxuzhonghu deleted the rm-v1alpha1 branch February 28, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove v1alpha1 API
4 participants