Use server side namespace filter #429
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@ahg-g I can take a look about the integration tests. |
hzxuzhonghu
changed the title
k8s-ci-robot
added
needs-rebase
hzxuzhonghu
changed the title
k8s-ci-robot
removed
the
needs-rebase
|
/retest |
pkg/epp/controller/pod_reconciler.go
Outdated
| Scheme *runtime.Scheme | ||
| // namespace of the InferencePool | ||
| // we donot support cross namespace pod selection | ||
| Namespace string |
There was a problem hiding this comment.
we don't need this anymore, right?
cmd/epp/main.go
Outdated
| @@ -140,7 +144,32 @@ func run() error { | |||
| return err | |||
| } | |||
|
|
|||
| mgr, err := ctrl.NewManager(cfg, ctrl.Options{Scheme: scheme}) | |||
| mgr, err := ctrl.NewManager(cfg, ctrl.Options{ | |||
There was a problem hiding this comment.
can we create a CreateDefaultManager func perhaps under the server pkg (https://github.com/kubernetes-sigs/gateway-api-inference-extension/tree/main/pkg/epp/server) so that we can invoke it from our integration tests, which would allow us to test this configuration.
k8s-ci-robot
added
size/L
pkg/epp/server/controller_manager.go
Outdated
| } | ||
|
|
||
| // NewDefaultManager creates a new controller manager with default configuration. | ||
| func NewDefaultManager(namespace, name string) (ctrl.Manager, error) { |
There was a problem hiding this comment.
can we invoke this from the tests please? Here https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/test/integration/hermetic_test.go#L493
There was a problem hiding this comment.
Let me see if there is a trap
There was a problem hiding this comment.
Updated, we should add more test cases later
There was a problem hiding this comment.
perhaps you forgot to push the update?
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
No description provided.