-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added cpu based example #436
Conversation
Hi @nirrozenbaum. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
53f30eb
to
447928b
Compare
Signed-off-by: Nir Rozenbaum <[email protected]>
/unhold |
/ok-to-test |
site-src/guides/index.md
Outdated
kubectl delete -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/raw/main/config/manifests/ext_proc.yaml --ignore-not-found | ||
kubectl delete -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/raw/main/config/manifests/gateway/gateway.yaml --ignore-not-found | ||
kubectl delete -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/raw/main/config/manifests/gateway/enable_patch_policy.yaml --ignore-not-found | ||
kubectl rollout restart deployment envoy-gateway -n envoy-gateway-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant this specific line: "kubectl rollout restart deployment envoy-gateway -n envoy-gateway-system"
Signed-off-by: Nir Rozenbaum <[email protected]>
/lgtm Feel free to unhold if you wish to keep it as is |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
I think we also need to update the manifest file name in the e2e test:
|
I am trying this cpu model server on a gke node. But my pods failed to spin up. Here are the logs:
Can I get some help on this? |
@liu-cong yes, this will be handled in a different PR I'm working on. as part of issue #435 EDIT: @liu-cong actually you're right. this should be fixed right away since it breaks existing code. I found few more places that reference this filepath and fixed them. pushing a PR and will tag you. |
@lliwenf I think there isn't enough cpu/memory allocated to the pod. |
fix #434