Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llmservice reconciler implementation #48

Merged
merged 1 commit into from
Nov 21, 2024
Merged

llmservice reconciler implementation #48

merged 1 commit into from
Nov 21, 2024

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Nov 20, 2024

Adding the LLMServiceReconciler and updating the datastore. Consuming the LLMService is considered out of scope of this PR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2024
@kfswain kfswain force-pushed the llmservice-impl branch 2 times, most recently from e064be7 to e4433bd Compare November 20, 2024 22:44
ahg-g
ahg-g reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a follow up PR to do the model name re-write, right?

@ahg-g
Copy link
Contributor

ahg-g commented Nov 20, 2024 •
edited
Loading

There is a follow up PR to do the model name re-write, right?

This is already mentioned in the description :)

@kfswain
Copy link
Collaborator Author

kfswain commented Nov 21, 2024

A couple small linter-error fixes made here as well.

@ahg-g
Copy link
Contributor

ahg-g commented Nov 21, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4cf17bb into kubernetes-sigs:main Nov 21, 2024
2 checks passed
@kfswain kfswain deleted the llmservice-impl branch December 4, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@robscott robscott Awaiting requested review from robscott

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kfswain @k8s-ci-robot @ahg-g