-
Notifications
You must be signed in to change notification settings - Fork 59
added support for testing cpu example in e2e tests #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/hold |
/unhold |
cc @danehans |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran e2e without setting HF_TOKEN and I get:
STEP: Checking if deployment default/my-pool status is: Available @ 03/13/25 16:40:43.353
panic: test timed out after 10m0s
running tests:
TestAPIs (10m0s)
goroutine 2334 [running]:
testing.(*M).startAlarm.func1()
/usr/local/go/src/testing/testing.go:2484 +0x394
created by time.goFunc
/usr/local/go/src/time/sleep.go:215 +0x2d
e2e needs to perform cleanup even when the token is not set or a timeout occurs.
Here is a failure when HF_TOKEN is not set using #488
[FAILED] in [BeforeSuite] - /home/solo-system-dhansen/gateway-api-inference-extension/test/e2e/epp/e2e_suite_test.go:220 @ 03/13/25 16:55:46.708
[BeforeSuite] [FAILED] [16.904 seconds]
[BeforeSuite]
/home/solo-system-dhansen/gateway-api-inference-extension/test/e2e/epp/e2e_suite_test.go:101
[FAILED] HF_TOKEN is not set
Expected
<string>:
not to be empty
In [BeforeSuite] at: /home/solo-system-dhansen/gateway-api-inference-extension/test/e2e/epp/e2e_suite_test.go:220 @ 03/13/25 16:55:46.708
------------------------------
e2e should also be updated to first check the HF_TOKEN env var so it can fail fast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to run it on GPUs? this didn't successfully run for me, the secret didn't get created.
@ahg-g I had a typo :/. |
Signed-off-by: Nir Rozenbaum <[email protected]>
Signed-off-by: Nir Rozenbaum <[email protected]>
Signed-off-by: Nir Rozenbaum <[email protected]>
Signed-off-by: Nir Rozenbaum <[email protected]>
/lgtm Tried it and works fine. |
/hold |
/approve cancel Sorry, I missed @danehans comment above |
@nirrozenbaum would you like to address @danehans comment above? |
@ahg-g yes, of course. |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix #435