Skip to content

added support for testing cpu example in e2e tests #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2025

Conversation

nirrozenbaum
Copy link
Contributor

@nirrozenbaum nirrozenbaum commented Mar 13, 2025

fix #435

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kfswain March 13, 2025 10:56
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2025
Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 16b7a10
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67d31a21080a0700088a7dcf
😎 Deploy Preview https://deploy-preview-485--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2025
@nirrozenbaum
Copy link
Contributor Author

/hold
I want to test it more before unholding.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@nirrozenbaum
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@nirrozenbaum
Copy link
Contributor Author

cc @danehans

Copy link
Contributor

@danehans danehans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran e2e without setting HF_TOKEN and I get:

  STEP: Checking if deployment default/my-pool status is: Available @ 03/13/25 16:40:43.353
panic: test timed out after 10m0s
	running tests:
		TestAPIs (10m0s)

goroutine 2334 [running]:
testing.(*M).startAlarm.func1()
	/usr/local/go/src/testing/testing.go:2484 +0x394
created by time.goFunc
	/usr/local/go/src/time/sleep.go:215 +0x2d

e2e needs to perform cleanup even when the token is not set or a timeout occurs.

Here is a failure when HF_TOKEN is not set using #488

[FAILED] in [BeforeSuite] - /home/solo-system-dhansen/gateway-api-inference-extension/test/e2e/epp/e2e_suite_test.go:220 @ 03/13/25 16:55:46.708
[BeforeSuite] [FAILED] [16.904 seconds]
[BeforeSuite]
/home/solo-system-dhansen/gateway-api-inference-extension/test/e2e/epp/e2e_suite_test.go:101

  [FAILED] HF_TOKEN is not set
  Expected
      <string>:
  not to be empty
  In [BeforeSuite] at: /home/solo-system-dhansen/gateway-api-inference-extension/test/e2e/epp/e2e_suite_test.go:220 @ 03/13/25 16:55:46.708
------------------------------

e2e should also be updated to first check the HF_TOKEN env var so it can fail fast.

Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try to run it on GPUs? this didn't successfully run for me, the secret didn't get created.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2025
@nirrozenbaum
Copy link
Contributor Author

Did you try to run it on GPUs? this didn't successfully run for me, the secret didn't get created.

@ahg-g I had a typo :/.
wrote in upper case instead lowercase.
it should work for you now.

Signed-off-by: Nir Rozenbaum <[email protected]>
Signed-off-by: Nir Rozenbaum <[email protected]>
Signed-off-by: Nir Rozenbaum <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Mar 13, 2025

/lgtm
/approve

Tried it and works fine.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Mar 13, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Mar 13, 2025

/approve cancel

Sorry, I missed @danehans comment above

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Mar 14, 2025

@nirrozenbaum would you like to address @danehans comment above?

@nirrozenbaum
Copy link
Contributor Author

@nirrozenbaum would you like to address @danehans comment above?

@ahg-g yes, of course.
can we do it in a follow up PR? this was also the case before this PR so technically this PR changed nothing in this aspect.

@ahg-g
Copy link
Contributor

ahg-g commented Mar 14, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Mar 14, 2025

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit a1c95a5 into kubernetes-sigs:main Mar 14, 2025
8 checks passed
@nirrozenbaum nirrozenbaum deleted the e2e-test branch March 14, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use cpu based Qwen model in e2e tests
4 participants