Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Proposal #5

Merged
merged 24 commits into from
Oct 4, 2024
Merged

API Proposal #5

merged 24 commits into from
Oct 4, 2024

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Sep 5, 2024

This PR contains the initial proposal for what the LLM Instance Gateway API surface might look like. Much of this is rough-in, and expected to change.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2024
ahg-g
ahg-g reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first round

raywainman
raywainman reviewed Sep 6, 2024
View reviewed changes
Joffref
Joffref reviewed Sep 8, 2024
View reviewed changes
Copy link

@Joffref Joffref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job so far! It's definitely something I'm looking to use in the future.

P.S.: It's my first review on a Kubernetes project, so if I made any mistakes, feel free to let me know.

@kfswain kfswain mentioned this pull request Sep 12, 2024
Closed
11 tasks
@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 29, 2024 •
edited
Loading

/assign would like to help review, ping myself for a mark

@kfswain
Copy link
Collaborator Author

kfswain commented Oct 3, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 3, 2024
ahg-g
ahg-g reviewed Oct 4, 2024
View reviewed changes
docs/proposals/002-api-proposal/proposal.md
// services should be consumed by only the backendpool they are part
// of. Should this behavior be breached, routing behavior is not
// guaranteed.
ServiceRef []corev1.ObjectReference
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be set on the httpRoute, this is only to identify the backends.

ahg-g
ahg-g reviewed Oct 4, 2024
View reviewed changes
@ahg-g
Copy link
Contributor

ahg-g commented Oct 4, 2024

/lgtm
/approve

Congratulations!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0f4522e into kubernetes-sigs:main Oct 4, 2024
2 checks passed
@Joffref
Copy link

Joffref commented Oct 4, 2024

Congrats!

@kfswain kfswain mentioned this pull request Oct 16, 2024
Merged
@kfswain kfswain deleted the api-proposal branch October 28, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raywainman raywainman raywainman left review comments

@robscott robscott robscott left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@terrytangyuan terrytangyuan terrytangyuan left review comments

@gyliu513 gyliu513 gyliu513 left review comments

@yuzisun yuzisun yuzisun left review comments

@arkodg arkodg arkodg left review comments

@coolkp coolkp coolkp left review comments

@ahg-g ahg-g ahg-g left review comments

@Joffref Joffref Joffref left review comments

Assignees

@ahg-g ahg-g

@Xunzhuo Xunzhuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.