Refactor beforeSuite in integration tests #508
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm One little nit-level comment. Otherwise looks great. Thanks! |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
I don't see the comment :) |
| pod := utiltesting.MakePod(pod.NamespacedName.Name). | ||
| Namespace(pod.NamespacedName.Namespace).Complete().ObjRef() | ||
|
|
||
| if err := k8sClient.Delete(context.Background(), pod); err != nil { | ||
| logutil.Fatal(logger, err, "Failed to delete pod", "pod", fakePod) | ||
| } | ||
| } | ||
| for _, m := range opts.models { | ||
| if err := k8sClient.Delete(context.Background(), m); err != nil { |
There was a problem hiding this comment.
Does DeleteAllOf() not work here?
There was a problem hiding this comment.
for some reason it didn't work, I will look into it later.
😭 It helps if I press the button. Apologies lol |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Another incremental cleanup to the integration tests.
@kfswain