Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ext_proc.yaml to inferencepool.yaml #515

Merged
merged 3 commits into from
Mar 17, 2025

Conversation

ahg-g
Copy link
Contributor

@ahg-g ahg-g commented Mar 17, 2025

InferencePool is the primary object for which all the other artifacts are being created (the epp service, deployment and rbac), so it makes sense to lead with that as the name of the yaml file.

Also renamed the epp deployment name to match the name used for the inferencePool

@k8s-ci-robot k8s-ci-robot requested a review from Jeffwan March 17, 2025 18:21
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from kfswain March 17, 2025 18:21
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2025
Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit fac33cc
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67d89203398e710008819c53
😎 Deploy Preview https://deploy-preview-515--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfswain
Copy link
Collaborator

kfswain commented Mar 17, 2025

/lgtm
/hold

I think we should drop the ext-proc terminology from anything user facing, they shouldnt need to worry about those particulars, and we can just call it EPP. Otherwise LGTM

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 17, 2025

/lgtm /hold

I think we should drop the ext-proc terminology from anything user facing, they shouldnt need to worry about those particulars, and we can just call it EPP. Otherwise LGTM

done, also reverted the my-pool part since merging this will cause a conflict in #516

```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is cracking me up. What even changed??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably my emacs cleaned up a space or newline :)

@kfswain
Copy link
Collaborator

kfswain commented Mar 17, 2025

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 17, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit a591cd0 into kubernetes-sigs:main Mar 17, 2025
8 checks passed
@ahg-g ahg-g mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants