-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ext_proc.yaml to inferencepool.yaml #515
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm I think we should drop the ext-proc terminology from anything user facing, they shouldnt need to worry about those particulars, and we can just call it EPP. Otherwise LGTM |
done, also reverted the my-pool part since merging this will cause a conflict in #516 |
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff is cracking me up. What even changed??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably my emacs cleaned up a space or newline :)
/lgtm Thanks! |
/hold cancel |
InferencePool is the primary object for which all the other artifacts are being created (the epp service, deployment and rbac), so it makes sense to lead with that as the name of the yaml file.
Also renamed the epp deployment name to match the name used for the inferencePool