Skip to content

Move benchmark under tools #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions site-src/performance/benchmark/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ to specify what this benchmark is for. For instance, `inference-extension` or `k
the script below will watch for that log line and then start downloading results.

```bash
benchmark_id='my-benchmark' ./benchmark/download-benchmark-results.bash
benchmark_id='my-benchmark' ./tools/benchmark/download-benchmark-results.bash
```

1. After the script finishes, you should see benchmark results under `./benchmark/output/default-run/my-benchmark/results/json` folder.
1. After the script finishes, you should see benchmark results under `./tools/benchmark/output/default-run/my-benchmark/results/json` folder.

### Tips

Expand All @@ -89,10 +89,10 @@ This guide shows how to run the jupyter notebook using vscode.
1. Install the dependencies.

```bash
pip install -r ./benchmark/requirements.txt
pip install -r ./tools/benchmark/requirements.txt
```

1. Open the notebook `./benchmark/benchmark.ipynb`, and run each cell. At the end you should
1. Open the notebook `./tools/benchmark/benchmark.ipynb`, and run each cell. At the end you should
see a bar chart like below:

![alt text](example-bar-chart.png)
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ benchmark_output_dir=${SCRIPT_DIR}/${output_dir}/${run_id}/${benchmark_id}

echo "Saving benchmark results to ${benchmark_output_dir}/results/json/"
download_benchmark_results
kubectl delete -f ${SCRIPT_DIR}/../config/manifests/benchmark/benchmark.yaml
kubectl delete -f ${SCRIPT_DIR}/../../config/manifests/benchmark/benchmark.yaml
File renamed without changes.