-
Notifications
You must be signed in to change notification settings - Fork 59
Document model server compatibility and config options #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/hold I will wait for the Triton metric PR to be merged. |
/retest |
Will you link that PR here so there is a paper trail? |
8bd3485
to
7fa5b46
Compare
This is already available in the latest Triton release. Just updated the PR to reflect that. This is ready to go! @kfswain |
@ahg-g The latest Triton release is out, I updated. This is ready to be merged. Pls review. Thanks! @BenjaminBraunDev Pls verify the Triton specific metrics configuration is correct. |
7fa5b46
to
1d6e486
Compare
@liu-cong One flag you might want to add below the
|
1d6e486
to
d103486
Compare
Great suggestion! Added |
d103486
to
4fd6ab6
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, liu-cong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Fixes #482
Part of #523
Tested updated helm chart:
And the output yaml contained the Triton specific metrics: