Skip to content

Document model server compatibility and config options #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Mar 19, 2025

Fixes #482

Part of #523

Tested updated helm chart:

 helm template epp config/charts/inferencepool/ --set inferencePool.modelServers.matchLabels.app=vllm-llama3-8b-instruct --set provider.name=gke --set inferencePool.modelServerType=triton-tensorrt-llm

And the output yaml contained the Triton specific metrics:

containers:
      - name: epp
        image: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp:main
        imagePullPolicy: Always
        args:
        - -poolName
        - epp
        - -poolNamespace
        - default
        - -v
        - "3"
        - -grpcPort
        - "9002"
        - -grpcHealthPort
        - "9003"
        - -metricsPort
        - "9090"
        - -totalQueuedRequestsMetric
        - "nv_trt_llm_request_metrics{request_type=waiting}"
        - -kvCacheUsagePercentageMetric
        - "nv_trt_llm_kv_cache_block_metrics{kv_cache_block_type=fraction}"

@k8s-ci-robot k8s-ci-robot requested a review from kfswain March 19, 2025 17:40
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2025
@k8s-ci-robot k8s-ci-robot requested a review from robscott March 19, 2025 17:40
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit fc65688
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67f94f05f17555000870fbdb
😎 Deploy Preview https://deploy-preview-537--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2025
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@liu-cong
Copy link
Contributor Author

/hold I will wait for the Triton metric PR to be merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2025
@kfswain
Copy link
Collaborator

kfswain commented Mar 21, 2025

/retest

@kfswain
Copy link
Collaborator

kfswain commented Apr 9, 2025

I will wait for the Triton metric PR to be merged.

Will you link that PR here so there is a paper trail?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2025
@liu-cong
Copy link
Contributor Author

liu-cong commented Apr 9, 2025

Will you link that PR here so there is a paper trail?

This is already available in the latest Triton release. Just updated the PR to reflect that. This is ready to go! @kfswain

@liu-cong
Copy link
Contributor Author

liu-cong commented Apr 9, 2025

@ahg-g The latest Triton release is out, I updated. This is ready to be merged. Pls review. Thanks!

@BenjaminBraunDev Pls verify the Triton specific metrics configuration is correct.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2025
@BenjaminBraunDev
Copy link
Contributor

@liu-cong One flag you might want to add below the totalQueuedRequestsMetric and kvCacheUsagePercentageMetric is an empty loraInfoMetric to tell the metrics scraper not to attempt to scrap LoRA metrics for triton since they won't be present:

- -loraInfoMetric
- ""

@liu-cong
Copy link
Contributor Author

@liu-cong One flag you might want to add below the totalQueuedRequestsMetric and kvCacheUsagePercentageMetric is an empty loraInfoMetric to tell the metrics scraper not to attempt to scrap LoRA metrics for triton since they won't be present:

- -loraInfoMetric
- ""

Great suggestion! Added

@ahg-g
Copy link
Contributor

ahg-g commented Apr 11, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Apr 14, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 92431f5 into kubernetes-sigs:main Apr 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants