Simplifying EPP-side buffer #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ahg-g
reviewed
Mar 19, 2025
kfswain
force-pushed
the
race-condition-fix
branch
from
9777fbe to
709ef28
Compare
kfswain
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm This makes sense to me |
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the EPP can control the flow of ext-proc messages by calling srv.Recv(), and we need to buffer the body messages anyway, io.Pipe is an over complication and we can simply use a byte array.
Additional Notes:
io.Pipe used in this way can cause a race condition: if multiple go routines are created with writers in quick succession, there is a case where the thread scheduler will select a routine that has a writer out of order, and cause the corresponding reads to happen out of order, causing a bad json parse and a failure of the message read.
A following PR is going to parse the
content-lengthheader and set the byte slice to that length to further optimize and prevent unneeded reallocation of the underlying array.