Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Initialize RequestReceivedTimestamp #539

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Mar 19, 2025

See the difference of the e2e request latency after this fix. Before the e2e latency was showing 1 hour (the max bucket)

image

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2025
@k8s-ci-robot k8s-ci-robot requested a review from kfswain March 19, 2025 22:28
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2025
@k8s-ci-robot k8s-ci-robot requested a review from robscott March 19, 2025 22:28
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit de03eb3
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67db451167171b00087471bc
😎 Deploy Preview https://deploy-preview-539--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2025
@kfswain
Copy link
Collaborator

kfswain commented Mar 19, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Mar 20, 2025

is this marked WIP intentionally?

@liu-cong
Copy link
Contributor Author

I haven't tested it thus still WIP

@liu-cong liu-cong marked this pull request as ready for review March 20, 2025 03:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g March 20, 2025 03:27
@liu-cong
Copy link
Contributor Author

/unhold

@ahg-g
Copy link
Contributor

ahg-g commented Mar 20, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 03d8584 into kubernetes-sigs:main Mar 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants