Cleanup logging in the request scheduling path #583
Conversation
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -103,21 +103,21 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer) | |||
| if recvErr != nil { | |||
| // This error occurs very frequently, though it doesn't seem to have any impact. | |||
| // TODO Figure out if we can remove this noise. | |||
| loggerVerbose.Error(err, "Cannot receive stream request") | |||
| logger.V(logutil.DEFAULT).Error(err, "Cannot receive stream request") | |||
There was a problem hiding this comment.
Are we bumping this up to be a tad more noisy so we drive towards resolution?
There was a problem hiding this comment.
that is what I am thinking, is this error expected to happen frequently? what triggers it?
There was a problem hiding this comment.
Yeah, I think I support that.
I think @liu-cong originally made that comment. I remember sifting through the libraries we are calling and I ended up in the grpc codebase with inconclusive answers.
Either way we should get some visibility into this to resolve +1
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.