-
Notifications
You must be signed in to change notification settings - Fork 69
Add provider-specific manifests for BBR helm chart #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provider-specific manifests for BBR helm chart #585
Conversation
Hi @rramkumar1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rramkumar1!
74582cb
to
bbbcbf6
Compare
Thanks @rramkumar1! Hopefully @ahg-g or @kfswain can help with approval. /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, we need to do the same for epp.
is there something special we need to do for kGateway, or is it not supported yet?
bbbcbf6
to
24054c7
Compare
As per @danehans, kGateway would require some code changes in the controller to make this work so I will need a bit of time on that one. I can add a guide for EnvoyGateway once their InferencePool support is merged since I did quite a bit of testing against that initially and already know how to make it work. |
/approve Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @ahg-g @kfswain @robscott