Skip to content

Renaming resources to better mirror how names are expected to be used #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Renaming resources to better mirror how names are expected to be used #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/manifests/inferencemodel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: inference.networking.x-k8s.io/v1alpha2
kind: InferenceModel
metadata:
name: inferencemodel-sample
name: tweet-summarizer
spec:
modelName: tweet-summary
criticality: Critical
Expand All @@ -15,7 +15,7 @@ spec:
apiVersion: inference.networking.x-k8s.io/v1alpha2
kind: InferenceModel
metadata:
name: inferencemodel-base-model
name: base-model
spec:
modelName: meta-llama/Llama-2-7b-hf
criticality: Critical
Expand All @@ -26,7 +26,7 @@ spec:
apiVersion: inference.networking.x-k8s.io/v1alpha2
kind: InferenceModel
metadata:
name: inferencemodel-base-model-cpu
name: base-model-cpu
spec:
modelName: Qwen/Qwen2.5-1.5B-Instruct
criticality: Critical
Expand Down
4 changes: 2 additions & 2 deletions config/samples/gateway_v1alpha1_inferencemodel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ metadata:
labels:
app.kubernetes.io/name: api
app.kubernetes.io/managed-by: kustomize
name: inferencemodel-sample
name: sample-sql-assist
spec:
criticality: Critical
modelName: sql-code-assist
poolRef:
name: inferencepool-sample
name: vllm-llama-31-8b-sample-pool
targetModels:
- name: npc-bot-v1
weight: 50
Expand Down
2 changes: 1 addition & 1 deletion config/samples/gateway_v1alpha1_inferencepool.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
labels:
app.kubernetes.io/name: api
app.kubernetes.io/managed-by: kustomize
name: inferencepool-sample
name: vllm-llama-31-8b-sample-pool
spec:
selector:
app: npc-bot
Expand Down
8 changes: 4 additions & 4 deletions test/testdata/inferencepool-with-model-hermetic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ spec:
apiVersion: inference.networking.x-k8s.io/v1alpha2
kind: InferenceModel
metadata:
name: inferencemodel-sample
name: sample
namespace: default
spec:
modelName: sql-lora
Expand All @@ -27,7 +27,7 @@ spec:
apiVersion: inference.networking.x-k8s.io/v1alpha2
kind: InferenceModel
metadata:
name: inferencemodel-sheddable
name: sheddable
namespace: default
spec:
modelName: sql-lora-sheddable
Expand All @@ -40,7 +40,7 @@ spec:
apiVersion: inference.networking.x-k8s.io/v1alpha2
kind: InferenceModel
metadata:
name: inferencemodel-generic
name: generic
namespace: default
spec:
modelName: my-model
Expand All @@ -54,7 +54,7 @@ spec:
apiVersion: inference.networking.x-k8s.io/v1alpha2
kind: InferenceModel
metadata:
name: inferencemodel-direct-model-name
name: direct-model-name
namespace: default
spec:
modelName: direct-model
Expand Down