-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow defining a default base model in the lora syncer configuration #609
Conversation
Hi @kaushikmitr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added default base model functionality to config map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, can you please also update:
-
The ConfigMap in the deployment manifests to only set the defaultBaseModel: https://github.com/kubernetes-sigs/gateway-api-inference-extension/tree/main/config/manifests/vllm
-
The manifests in the guide to use the defaultBaseModel: https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/site-src/guides/adapter-rollout.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated public docs and deployment yaml
@@ -66,7 +66,7 @@ spec: | |||
- name: lora-adapter-syncer | |||
tty: true | |||
stdin: true | |||
image: <SIDECAR_IMAGE> | |||
image: us-docker.pkg.dev/kaushikmitra-gke-dev/kaushikmitra-docker-repo/ora_sidecar_test:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/lora-syncer:main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kaushikmitr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
This pull request introduces a new feature to set a default base model for LoRA adapters, which simplifies the configuration by reducing repetition. The most important changes include updates to configuration files, documentation, and the sidecar code to support this new feature.
New Feature: Default Base Model for LoRA Adapters
config/manifests/vllm/gpu-deployment.yaml
: AddeddefaultBaseModel
field to specify a default base model for all adapters when not specified individually. Removed redundantbase-model
entries from individual adapters.site-src/guides/adapter-rollout.md
: Updated ConfigMap examples to include thedefaultBaseModel
field and removed redundantbase-model
entries from individual adapters.tools/dynamic-lora-sidecar/README.md
: Updated documentation to explain the newdefaultBaseModel
field and provided example configurations.tools/dynamic-lora-sidecar/deployment.yaml
: Updated deployment configuration to usedefaultBaseModel
and removed redundantbase-model
entries from individual adapters.tools/dynamic-lora-sidecar/sidecar/sidecar.py
: Addeddefault_base_model
property to retrieve the default base model from the configuration and used it inensure_exist_adapters
andensure_not_exist_adapters
methods.tools/dynamic-lora-sidecar/sidecar/validation.yaml
: Updated schema validation to includedefaultBaseModel
and adjusted descriptions forbase-model
to indicate it overrides the default base model.