Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining a default base model in the lora syncer configuration #609

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

kaushikmitr
Copy link
Contributor

@kaushikmitr kaushikmitr commented Mar 28, 2025

This pull request introduces a new feature to set a default base model for LoRA adapters, which simplifies the configuration by reducing repetition. The most important changes include updates to configuration files, documentation, and the sidecar code to support this new feature.

New Feature: Default Base Model for LoRA Adapters

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kaushikmitr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2025
Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 0562977
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67e72c43b6d160000802fb5d
😎 Deploy Preview https://deploy-preview-609--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Mar 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2025
Copy link
Contributor Author

@kaushikmitr kaushikmitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added default base model functionality to config map

Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, can you please also update:

  1. The ConfigMap in the deployment manifests to only set the defaultBaseModel: https://github.com/kubernetes-sigs/gateway-api-inference-extension/tree/main/config/manifests/vllm

  2. The manifests in the guide to use the defaultBaseModel: https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/site-src/guides/adapter-rollout.md

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2025
Copy link
Contributor Author

@kaushikmitr kaushikmitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated public docs and deployment yaml

@@ -66,7 +66,7 @@ spec:
- name: lora-adapter-syncer
tty: true
stdin: true
image: <SIDECAR_IMAGE>
image: us-docker.pkg.dev/kaushikmitra-gke-dev/kaushikmitra-docker-repo/ora_sidecar_test:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/lora-syncer:main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ahg-g
Copy link
Contributor

ahg-g commented Mar 28, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kaushikmitr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Mar 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit 7cd4460 into kubernetes-sigs:main Mar 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants