Skip to content

Adding terminationGracePeriodSeconds to match vLLMs #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

Adding terminationGracePeriodSeconds to match vLLMs #614

merged 1 commit into from
Mar 31, 2025

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Mar 30, 2025 •
edited
Loading

Fixes #548
Tested 3 scenarios:

  • Scale up to 4 replicas
  • Scale down to 1 replica
  • Rollout restart a single replica

There are small dips in the metric, but the largest dip was on scale up, so I believe the QPS dip is due to imperfect metric read as instances come up/down
image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2025
@k8s-ci-robot k8s-ci-robot requested a review from danehans March 30, 2025 06:16
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from robscott March 30, 2025 06:16
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 30, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit cfafbca
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67eac8e34c3d1d0009cca80c
😎 Deploy Preview https://deploy-preview-614--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Mar 31, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1ce8273 into kubernetes-sigs:main Mar 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@danehans danehans Awaiting requested review from danehans

@robscott robscott Awaiting requested review from robscott

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EPP should gracefully rollout and drain
3 participants
@kfswain @k8s-ci-robot @ahg-g