Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Groupversion #63

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fixing Groupversion #63

merged 1 commit into from
Dec 3, 2024

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Dec 2, 2024 •
edited
Loading

Fixing groupversion

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 2, 2024
ahg-g
ahg-g reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to split the traffic splitting into its own PR

@kfswain kfswain force-pushed the llmservice-integration branch from d46a884 to 5a8385e Compare December 3, 2024 17:19
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 3, 2024
@kfswain kfswain force-pushed the llmservice-integration branch from 5a8385e to 553c9d2 Compare December 3, 2024 17:20
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2024
@kfswain kfswain force-pushed the llmservice-integration branch 2 times, most recently from dee4ef5 to 3b23ebb Compare December 3, 2024 20:25
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 3, 2024
@kfswain
integrating LLMService & random weighted draw
72c1e27 
Also cleaning up groupversion data
@kfswain kfswain force-pushed the llmservice-integration branch from 3b23ebb to 72c1e27 Compare December 3, 2024 20:26
@kfswain
Copy link
Collaborator Author

kfswain commented Dec 3, 2024

@ahg-g updated

@ahg-g
Copy link
Contributor

ahg-g commented Dec 3, 2024

/lgtm

can you change the title as well please?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit fcaaef2 into kubernetes-sigs:main Dec 3, 2024
2 checks passed
@kfswain kfswain changed the title integrating LLMService & random weighted draw Fixing Groupversion Dec 3, 2024
@kfswain kfswain deleted the llmservice-integration branch December 4, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@robscott robscott Awaiting requested review from robscott

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kfswain @k8s-ci-robot @ahg-g