Add response body handler #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
ahg-g
reviewed
Dec 16, 2024
ahg-g
reviewed
Dec 17, 2024
| return nil, fmt.Errorf("unmarshaling response body: %v", err) | ||
| } | ||
| reqCtx.Response = res | ||
| klog.V(3).Infof("Response: %+v", res) |
There was a problem hiding this comment.
same here, the response is just as big as the body, right?
There was a problem hiding this comment.
Actually not, the response here only contains the fields we are interested in (the number of tokens).
5 tasks
|
/approve Thanks Cong |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, liu-cong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a response body handler, which parses the inference response with
usagestats such ascompletion_tokens.This is the prerequisite for adding metrics such as per output token latency.