You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: geps/gep-1762.md
+5-6
Original file line number
Diff line number
Diff line change
@@ -77,7 +77,7 @@ Some common requirements would be:
77
77
* Any other arbitrary fields; the list is unbounded. Some examples would be:
78
78
* CPU and memory requests
79
79
* Service `externalTrafficPolicy`
80
-
* Affinity rules.
80
+
* Affinity rules
81
81
82
82
This GEP currently only aims to solve a subset of these concerns. Additional concerns may be addressed in future revisions or other GEPs.
83
83
@@ -87,7 +87,7 @@ This is handled by [GEP-1651](https://github.com/kubernetes-sigs/gateway-api/pul
87
87
88
88
#### Gateway IP
89
89
90
-
This section just clarifies and existing part of the spec, how to handle `.spec.addresses` for in-cluster implementations.
90
+
This section just clarifies an existing part of the spec, how to handle `.spec.addresses` for in-cluster implementations.
91
91
Like all other Gateway types, this should impact the address the `Gateway` is reachable at.
92
92
93
93
For implementations using a `Service`, this means the `clusterIP` or `loadBalancerIP` (depending on the `Service` type).
@@ -112,7 +112,6 @@ spec:
112
112
113
113
This would generate a `Service` with `clusterIP` or `loadBalancerIP`, depending on the Service type.
114
114
115
-
116
115
#### Labels and Annotations
117
116
118
117
Labels and annotations for generated resources are specified in `infrastructure`:
@@ -138,7 +137,7 @@ This is typically not a concern; however, if an implementation is aware of speci
138
137
exclude these from irrelevant resources.
139
138
140
139
This is intended to clearly identify resources associated with a specific application, environment, or Gateway.
141
-
Additionally, it can be used support integration with the kitchen-sync of Kubernetes extensions which rely on labels and annotations.
140
+
Additionally, it can be used support integration with the kitchen-sink of Kubernetes extensions which rely on labels and annotations.
142
141
143
142
Validation will be added to prevent any usage with `gateway.networking.k8s.io/` prefix, to avoid conflicts with `gateway.networking.k8s.io/gateway-name` or other future additions.
144
143
@@ -150,7 +149,7 @@ This can be utilized for the remainder of customizations.
150
149
151
150
### Resource Attachment
152
151
153
-
Resources Generated in response to the `Gateway` will have two attributes:
152
+
Resources generated in response to the `Gateway` will have two attributes:
154
153
155
154
* A `gateway.networking.k8s.io/gateway-name: <NAME>` label.
156
155
* A name `<NAME>-<GATEWAY CLASS>`. This format is not strictly required for implementations, but strongly recommended for consistency in attachment.
@@ -208,7 +207,7 @@ spec:
208
207
selector:
209
208
# Match the generated Deployment by label
210
209
matchLabels:
211
-
gateway.networking.k8s.io/metadata.name: gateway
210
+
gateway.networking.k8s.io/gateway-name: gateway
212
211
```
213
212
214
213
Note: there is [discussion](https://github.com/kubernetes-sigs/gateway-api/discussions/1355) around a way to attach a HPA to a Gateway directly.
0 commit comments