Skip to content

Reverting GEP 735 from implemented to provisional #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022

Conversation

robscott
Copy link
Member

@robscott robscott commented May 2, 2022

What type of PR is this?
/kind cleanup
/kind gep
/kind api-change

What this PR does / why we need it:
API review for v0.5.0 raised some important questions that we didn't have great answers for. This temporarily removes this change until we can more clearly answer the questions and/or adjust the approach.

Which issue(s) this PR fixes:
Fixes #1127

Does this PR introduce a user-facing change?:

Address matching has been removed from TCP and UDP routes. This feature was never released, but represents a broader concept we're still interested in including in the API, it just likely requires more work to ensure we've thought through every possible use case and interpretation.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/gep PRs related to Gateway Enhancement Proposal(GEP) kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin May 2, 2022 20:43
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022
@robscott
Copy link
Member Author

robscott commented May 2, 2022

This is a big change, adding a hold for consensus. I did chat with @shaneutt this morning to ensure this made sense to him, and there has been support on the corresponding issue (#1127) and community meeting.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2022
API review for v0.5.0 raised some important questions that we didn't
have great answers for. This temporarily removes this change until we
can more clearly answer the questions and/or adjust the approach.
@robscott robscott force-pushed the revert-address-match branch from ebd02a2 to d5e92da Compare May 2, 2022 23:45
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 2, 2022
@youngnick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2022
@shaneutt
Copy link
Member

shaneutt commented May 4, 2022

/lgtm

@robscott
Copy link
Member Author

robscott commented May 5, 2022

Discussed at community meeting, seems like we've got consensus on this, removing the hold.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8d7fb06 into kubernetes-sigs:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider holding GEP 735 for a future release (after v0.5.0)
4 participants