-
Notifications
You must be signed in to change notification settings - Fork 536
Reverting GEP 735 from implemented to provisional #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverting GEP 735 from implemented to provisional #1139
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
API review for v0.5.0 raised some important questions that we didn't have great answers for. This temporarily removes this change until we can more clearly answer the questions and/or adjust the approach.
ebd02a2
to
d5e92da
Compare
/lgtm |
/lgtm |
Discussed at community meeting, seems like we've got consensus on this, removing the hold. /hold cancel |
What type of PR is this?
/kind cleanup
/kind gep
/kind api-change
What this PR does / why we need it:
API review for v0.5.0 raised some important questions that we didn't have great answers for. This temporarily removes this change until we can more clearly answer the questions and/or adjust the approach.
Which issue(s) this PR fixes:
Fixes #1127
Does this PR introduce a user-facing change?: