Skip to content

chore(conformance): shorten the resource name #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(conformance): shorten the resource name #2589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conformance/tests/httproute-invalid-parentref-section-name-not-matching-port.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var HTTPRouteInvalidParentRefSectionNameNotMatchingPort = suite.ConformanceTest{
Manifests: []string{"tests/httproute-invalid-parentref-section-name-not-matching-port.yaml"},
Test: func(t *testing.T, suite *suite.ConformanceTestSuite) {
routeNN := types.NamespacedName{Name: "httproute-listener-section-name-not-matching-port", Namespace: "gateway-conformance-infra"}
gwNN := types.NamespacedName{Name: "gateway-with-one-not-matching-port-and-section-name-route", Namespace: "gateway-conformance-infra"}
gwNN := types.NamespacedName{Name: "gw-with-one-section-name-not-matching-port-route", Namespace: "gateway-conformance-infra"}

// The Route must have an Accepted Condition with a NoMatchingParent Reason.
t.Run("HTTPRoute with sectionName does not match Port in ParentRef has an Accepted Condition with status False and Reason NoMatchingParent", func(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions conformance/tests/httproute-invalid-parentref-section-name-not-matching-port.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
name: gateway-with-one-not-matching-port-and-section-name-route
name: gw-with-one-section-name-not-matching-port-route
namespace: gateway-conformance-infra
spec:
gatewayClassName: "{GATEWAY_CLASS_NAME}"
Expand All @@ -22,7 +22,7 @@ metadata:
namespace: gateway-conformance-infra
spec:
parentRefs:
- name: gateway-with-one-not-matching-port-and-section-name-route
- name: gw-with-one-section-name-not-matching-port-route
namespace: gateway-conformance-infra
sectionName: http
# mismatched port value here (81 does not match gateway http listener's port) triggers NoMatchingParent reason
Expand Down