Fix CI failures for Go 1.17 and verifying invalid examples

[youngnick]

Signed-off-by: Nick Young [email protected]

What type of PR is this?

/kind cleanup
/kind failing-test

What this PR does / why we need it:
Fixes up the generated docs with Go 1.17 build tags, should mean they pass CI now.
Updates #828

It also turned out that the verify-examples script was failing and not actually testing what we though, so I fixed that as well.

[jpeach]

/lgtm

[howardjohn]

Would make generate on a local machine without go1.17 revert this now? So developers need to use 1.17 now? That seems ok, just wanted to check if that is the case

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [youngnick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[youngnick]

Would make generate on a local machine without go1.17 revert this now? So developers need to use 1.17 now? That seems ok, just wanted to check if that is the case

I'm not sure. It depends on what Go 1.16.x does with build tags that start with // +go:build instead of just // +build. But I think we should probably mandate 1.17 anyway, since all the tooling is now migrated.

[robscott]

🤦 I forgot about this part, it looks like we need to copy kubernetes/kubernetes#103692.

Boilerplate header is wrong for: /home/prow/go/src/sigs.k8s.io/gateway-api/apis/v1alpha2/zz_generated.deepcopy.go
Boilerplate header is wrong for: /home/prow/go/src/sigs.k8s.io/gateway-api/apis/v1alpha1/zz_generated.deepcopy.go

[robscott]

Better link: kubernetes/kubernetes@f11a3cd

[youngnick]

Looks like golangci-lint also has a deprecation that's causing a failure, sigh. I'll keep ticking things off.

[youngnick]

Okay, done. In total, this PR fixes the following:

• go build tags weren't getting parsed out properly, even after the migration to go 1.17
• turned out the invalid-examples thing wasn't actually checking anything. It should be slightly more reliable now. I've tried to comment this a bit.
• Debugging which test out of verify-all.sh was failing was tricky, I missed the go build tag lines failing for hours, so I added in some extra log lines to make it clearer when running in verbose mode.

[robscott]

Thanks @youngnick! A couple tiny nits but otherwise LGTM, this is a huge improvement.

[hbagdi]

/lgtm
Adding hold for Rob's comment.
/hold

[robscott]

Thanks!

/lgtm

[youngnick]

/hold cancel