-
Notifications
You must be signed in to change notification settings - Fork 159
Add StatusConflict http kind to userErrorCodeMap. #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StatusConflict http kind to userErrorCodeMap. #1846
Conversation
Welcome @halimsam! |
Hi @halimsam. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
84367c1
to
a8d3212
Compare
954f406
to
b1e5e5a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill, halimsam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.15 |
@amacaskill: new pull request created: #1850 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@halimsam: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
/cherry-pick release-1.14 |
@amacaskill: new pull request created: #1881 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR accounts for http error code 409 (Status conflict) and inputting it into the user error code map as FailedPrecondition. This will be used to filter out unactionable SLO triggering alerts.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
for internal bug.
Does this PR introduce a user-facing change?:
no
/assign mattcary