Add support for HdHA disk provisioning

[tonyzhc]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for the PDCSI driver to provision Hyperdisk-balanced High Availability (HdHA) disks. This allows users to use the latest generation of regional disks from GCE. The feature is gated behind flag allow-hdha-provisioning.

Which issue(s) this PR fixes:

Fixes b/391964605

Special notes for your reviewer:

One potential gap I observe is that we have to return the raw GCE error if users call ControllerPublishVolume on a HdHA disk in read only mode, because we cannot determine the disk type without actually fetching the disk. I think this is mostly fine since the GCE error is pretty clear (" Error 400: The disk cannot be attached with READ_ONLY mode."), but please let me know if I should add some more explicit error message.

Does this PR introduce a user-facing change?:

Add support for provisioning Hyperdisk-balanced High Availability disks.

[k8s-ci-robot]

Hi @tonyzhc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[leiyiz]

/ok-to-test
/kind feature

[tonyzhc]

/retest

[tonyzhc]

/retest

[amacaskill]

Integration test failed, but I think this is the snapshot race condition. https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_gcp-compute-persistent-disk-csi-driver/1915/pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration/1886853026778451968

/retest

[tonyzhc]

Can confirm that the integration test is failing because of the race condition between createSnapshot and attach/detachDisk (b/345837974): https://screenshot.googleplex.com/BeTmv9fojEWedUF.

[tonyzhc]

/retest

[amacaskill]

Please fix the latest comments I left here and over chat, then I will take one last look. I think its pretty close at this point!

[amacaskill]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, tonyzhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amacaskill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[amacaskill]

I think we can revert this change

[tonyzhc]

Removed.

[amacaskill]

/lgtm

[amacaskill]

/retest

[amacaskill]

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

[amacaskill]

/lgtm

[tonyzhc]

/retest

[k8s-ci-robot]

@tonyzhc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration	6ecdd9b	link	true	/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
pull-gcp-compute-persistent-disk-csi-driver-e2e	6ecdd9b	link	true	/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.