Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Disk Topology Feature #1983

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

julianKatz
Copy link
Contributor

@julianKatz julianKatz commented Mar 6, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

This PR introduces a new, flag-gated feature: Disk Topology.

GKE will be adding new labels to its nodes that indicate the GCP disk products that each node is compatible with.

With the addition of these new disk type labels to nodes, we can include disk type labels in workload scheduling. To affect that, those labels will be included in a PersistentVolume's NodeAffinity clause. This PR includes a disk support label consistent with the type specified in the StorageClass in each of the Topology segments included in CreateVolumeResponse. External Provisioner will then read these and add them as NodeAffinity requirements on the PV.

The feature is gated on the newly introduced --disk-topology=[true|false] flag, which is disabled by default.

Special notes for your reviewer: None.

Does this PR introduce a user-facing change?:

Yes, users can set the flag to true and enable the new functionality.

Added disk topology feature, enabled using --disk-topology=true (default off).  Disk topology includes support for `topology.gke.io/[disk-type]: true` labels on nodes and adds a label in that format to each CreateVolumeRequest.Volume.AccessibleTopology segment, which equate to NodeAffinity blocks in the eventual Persistent Volume.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @julianKatz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2025
@julianKatz julianKatz force-pushed the machine-serenity-non-allowedTopologies-method branch from a23f433 to d73f071 Compare March 6, 2025 21:29
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2025
@julianKatz julianKatz force-pushed the machine-serenity-non-allowedTopologies-method branch from d73f071 to c0f81d1 Compare March 14, 2025 22:35
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2025
@julianKatz julianKatz force-pushed the machine-serenity-non-allowedTopologies-method branch from c0f81d1 to b2bf395 Compare March 14, 2025 22:36
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2025
@julianKatz julianKatz force-pushed the machine-serenity-non-allowedTopologies-method branch 4 times, most recently from d8497dd to baf7abf Compare March 14, 2025 22:47
@julianKatz julianKatz changed the title Half-made changes Introduce Disk Topology Feature Mar 14, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 14, 2025
@julianKatz julianKatz marked this pull request as ready for review March 14, 2025 23:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from leiyiz and mattcary March 14, 2025 23:09
@julianKatz julianKatz force-pushed the machine-serenity-non-allowedTopologies-method branch from baf7abf to df19d2a Compare March 17, 2025 20:50
@hungnguyen243
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 4, 2025
@julianKatz julianKatz force-pushed the machine-serenity-non-allowedTopologies-method branch from ad65c08 to 75188fd Compare April 7, 2025 18:32
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: julianKatz, tonyzhc
Once this PR has been reviewed and has the lgtm label, please assign mattcary for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tonyzhc
Copy link
Contributor

tonyzhc commented Apr 7, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2025
@julianKatz julianKatz force-pushed the machine-serenity-non-allowedTopologies-method branch from 75188fd to 51b7f9e Compare April 8, 2025 01:33
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

@julianKatz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022 3d848cf link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants