Supports static IPv4 assignment in VMware Windows OVA #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
laozc
force-pushed
the
static-ip-windows
branch
from
b44074b to
09e6108
Compare
mboersma
reviewed
Feb 17, 2025
laozc
force-pushed
the
static-ip-windows
branch
from
09e6108 to
5301e60
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
laozc
force-pushed
the
static-ip-windows
branch
from
5301e60 to
c412a96
Compare
|
Will have to take it on trust that this is fine as no longer an expert on unattend.xml /lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Supports static IPv4 assignment in VMware Windows OVA
The user may provide these input parameters with image-builder.
{ "ipv4_address_cidr": "192.168.88.2/24", "gateway4": "192.168.88.1", "dns_servers": "192.168.88.1" }Related issues
Additional context
Related doc from MSFT
https://learn.microsoft.com/en-us/windows-hardware/customize/desktop/unattend/microsoft-windows-tcpip
https://learn.microsoft.com/en-us/windows-hardware/customize/desktop/unattend/microsoft-windows-dns-client