Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Canonical MaaS Provider #1695

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vasartori
Copy link
Contributor

Change description

Add support for Canonica MaaS

Related issues

Additional context

Initially, this version supports only Ubuntu 22.04 and Ubuntu 24.04, both in the UEFI version.
After some time, we can start adding other operating systems, such as Rocky Linux 9.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vasartori. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 25, 2025
@vasartori vasartori force-pushed the feature-maas-provider branch from b2adecb to 5e7718d Compare February 25, 2025 16:58
@vasartori
Copy link
Contributor Author

@AverageMarcus Could you please take a look at this PR and review it? I probably forgot somethig, and you have more experience than me with image-builder.

@mboersma
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2025
@vasartori
Copy link
Contributor Author

/retest

@vasartori vasartori force-pushed the feature-maas-provider branch from 4c576b6 to a6c4596 Compare March 10, 2025 19:05
@vasartori
Copy link
Contributor Author

vasartori commented Mar 11, 2025

@mboersma @AverageMarcus @drew-viles
As we discussed in the Office Hours meeting, if I understand correctly, to approve this PR we need:

  • Owners file: Do we need to create a new one? I'm not familiar with it... We have added the owners file, needs approve.
  • Readme file for the MAAS provider (or is it a generic guide for adding new providers?):
    • How to test it
    • The steps to add a new provider
    • A note about the limited E2E test coverage
      Where is the best place to put this README? Does it make sense to include it in this PR?

Copy link

linux-foundation-easycla bot commented Mar 14, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vasartori / name: Victor Sartori (a6c4596)
  • ✅ login: silviourbano / name: Silvio Rubio (bb295ba, d895b36)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 14, 2025
@mboersma
Copy link
Contributor

@vasartori we can't merge this until the OWNERS file is valid, which requires its members to join the Kubernetes org on GitHub. It's not a high hurdle, but you need to be sponsored and follow this process:
https://github.com/kubernetes/community/blob/master/community-membership.md

As for the README.md, I think it should go at images/capi/packer/maas/README.md where you put it, and that content looks good to me.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 19, 2025
@vasartori
Copy link
Contributor Author

@mboersma and @drew-viles, after a long time, I’ve started the request to join the Kubernetes SIG as a member.
Could you please approve the issue?
kubernetes/org#5526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canonical MaaS as an Image Provider
4 participants