Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding RockyLinux to openstack #1706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding RockyLinux to openstack #1706

wants to merge 1 commit into from

Conversation

drew-viles
Copy link
Contributor

Change description

This change introduces a RockyLinux target for the OpenStack builder - finally 😆

To do this I've also added an OpenStack goss var for RockyLinux & Ubuntu builds for OpenStack to prevent it failing when looking for cloud-utils in RockyLinux (it was just set to qemu all this time, evidently was fine for Ubuntu ¯\_(ツ)_/¯ ).
The security role has been adjusted too so that Debian or Redhat based tasks are performed together within a block.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from drew-viles. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2025
@drew-viles
patch: adding rockylinux support to openstack and updating rockylinux…
99b3857 
… goss package args from cloud-utils to cloud-utils-growpart.
@drew-viles drew-viles force-pushed the openstack-rockylinux branch from d1987c5 to 99b3857 Compare March 18, 2025 23:04
kkeshavamurthy
kkeshavamurthy reviewed Apr 10, 2025
View reviewed changes
images/capi/packer/goss/goss-vars.yaml
service:
iscsid:
enabled: true
running: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering why the nutanix block is being remove here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erm, good question, I had no reason to remove this that I can recall!
Been a while since I raised this though but is probably in error, let me re-add it and check and then I'll nudge again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkeshavamurthy kkeshavamurthy kkeshavamurthy left review comments

@mboersma mboersma Awaiting requested review from mboersma

@AverageMarcus AverageMarcus Awaiting requested review from AverageMarcus

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drew-viles @k8s-ci-robot @kkeshavamurthy